linux-kernel - Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120627172130.GD7472@merlins.org>
Date:	Wed, 27 Jun 2012 10:21:30 -0700
From:	Marc MERLIN <marc@...lins.org>
To:	Alexander Block <ablock84@...glemail.com>
Cc:	linux-btrfs@...r.kernel.org, dave@...os.cz, hch@...radead.org,
	linux-fsdevel@...r.kernel.org, chris.mason@...ionio.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)

On Wed, Jun 20, 2012 at 12:35:11PM +0200, Alexander Block wrote:
> Hello,
> 
> This is the second attempt to bring in cross subvolume reflinks into btrfs.
> The first attempt was NAKed due to missing vfs mount checks and a clear
> description of what btrfs subvolumes are and probably also why cross 
> subvolume reflinks are ok in the case of btrfs. This version of the patch 
> comes from David and is in SUSE kernels since a long time, so it is tested 
> and working. The patch also does proper vfs mount checks, so cross mount 
> point reflinks are not possible with this patch. It only allows cross 
> reflinks between two subvolumes which are in the same mount point. 
 
Thank you for bringing this back. This would have saved me a lot of
trouble

I'm not familiar with the code, but here's a big thumbs up from me.

Anyone doing reviews, please consider this :)

Thanks,
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/