linux-kernel - Re: [PATCH v3 3/3] perf script/python: Pass event/thread/dso name and symbol info to event handler in python

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120627185817.GD20530@infradead.org>
Date:	Wed, 27 Jun 2012 15:58:17 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Feng Tang <feng.tang@...el.com>
Cc:	David Ahern <dsahern@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Robert Richter <robert.richter@....com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v3 3/3] perf script/python: Pass event/thread/dso name
 and symbol info to event handler in python

Em Mon, Jun 18, 2012 at 02:10:39PM +0800, Feng Tang escreveu:
> Also as suggested by Arnaldo, pack all these parameters to a dictionary,
> which is more expandable for adding new parameters while keep the
> compatibility for old scripts.
> 
> Signed-off-by: Feng Tang <feng.tang@...el.com>
> ---
>  .../util/scripting-engines/trace-event-python.c    |   32 +++++++++++++++----
>  1 files changed, 25 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
> index 97f4fad..e8ac480 100644
> --- a/tools/perf/util/scripting-engines/trace-event-python.c
> +++ b/tools/perf/util/scripting-engines/trace-event-python.c
> @@ -336,15 +336,23 @@ static void python_process_general_event(union perf_event *pevent __unused,
>  				 struct machine *machine __unused,
>  				 struct addr_location *al)
>  {
> -	PyObject *handler, *retval, *t;
> +	PyObject *handler, *retval, *t, *dict;
>  	static char handler_name[64];
>  	unsigned n = 0;
> -	void *data = sample->raw_data;
> +	struct thread *thread = al->thread;
>  
> +	/*
> +	 * Use the MAX_FIELDS to make the function expandable, though
> +	 * currently there is only one itme for the tuple.
> +	 */
>  	t = PyTuple_New(MAX_FIELDS);
>  	if (!t)
>  		Py_FatalError("couldn't create Python tuple");
>  
> +	dict = PyDict_New();
> +	if (!dict)
> +		Py_FatalError("couldn't create Python dictionary");
> +
>  	snprintf(handler_name, sizeof(handler_name), "%s", "process_event");
>  
>  	handler = PyDict_GetItemString(main_dict, handler_name);
> @@ -353,14 +361,23 @@ static void python_process_general_event(union perf_event *pevent __unused,
>  		goto exit;
>  	}
>  
> -	/* Pass 4 parameters: event_attr, perf_sample, raw data, thread name */
> -	PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
> +	PyDict_SetItemString(dict, "ev_name", PyString_FromString(event_name(evsel)));
> +	PyDict_SetItemString(dict, "attr", PyString_FromStringAndSize(
>  			(const char *)&evsel->attr, sizeof(evsel->attr)));
> -	PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
> +	PyDict_SetItemString(dict, "sample", PyString_FromStringAndSize(
>  			(const char *)sample, sizeof(*sample)));
> -	PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
> -			data, sample->raw_size));
> +	PyDict_SetItemString(dict, "raw_buf", PyString_FromStringAndSize(
> +			(const char *)sample->raw_data, sample->raw_size));
> +	PyDict_SetItemString(dict, "comm",
> +			PyString_FromString(thread->comm));
> +	PyDict_SetItemString(dict, "dso",
> +			PyString_FromString(al->map->dso->name));
> +	if (al->sym) {
> +		PyDict_SetItemString(dict, "symbol",
> +			PyString_FromString(al->sym->name));
> +	}
>  
> +	PyTuple_SetItem(t, n++, dict);

Now old scrips will break, as the tuple they expect:

 (attr, sample, raw_data)

will not be there.

To not break those scripts you must leave it there and add the new ones
in a python compatible way. I.e. have you tested the existing scripts
using the new perf tool with your patches applied? They must continue to
work.

I.e. leave the old tuple and add the dict at the end somehow.

The first two patches in this series don't apply anymore, please find
them attached fixed, please check if they work as expected.

- Arnaldo

View attachment "0001-perf-script-Add-general-python-handler-to-process-no.patch" of type "text/plain" (4546 bytes)

View attachment "0002-perf-script-Replace-struct-thread-with-struct-addr_l.patch" of type "text/plain" (8378 bytes)