linux-kernel - [PATCH] [SCSI] bnx2i: add a prefix to a printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340825211.1911.42.camel@x61.thuisdomein>
Date:	Wed, 27 Jun 2012 21:26:51 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: [PATCH] [SCSI] bnx2i: add a prefix to a printk

During each suspend and resume cycle a mysterious message is added to
the logs:
    CPU 1 offline: Remove Rx thread

Some grepping of the tree revealed this message is printed by bnx2i.
Add a prefix to this message to make it clear that it is printed by
bnx2i. That should also make it obvious it is the mirror of the
    bnx2i: CPU 1 online: Create Rx thread

message.

Signed-off-by: Paul Bolle <pebolle@...cali.nl>
---
0) Untested!

1) I only noticed this because I've been looking at the log messages
generated by suspend and resume (for some iwlegacy and i915 issues) and
because Fedora 16 enables bnx2i by default.

2) This triggers a checkpatch warning:
    WARNING: Prefer pr_info(... to printk(KERN_INFO, ...

So I added Joe to the Cc's to suggest a way to make all printks in this
file end up with a "bnx2i:" prefix (or whatever prefix is preferred).

 drivers/scsi/bnx2i/bnx2i_init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 8b68167..b75864b 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -456,7 +456,8 @@ static int bnx2i_cpu_callback(struct notifier_block *nfb,
 		break;
 	case CPU_DEAD:
 	case CPU_DEAD_FROZEN:
-		printk(KERN_INFO "CPU %x offline: Remove Rx thread\n", cpu);
+		printk(KERN_INFO "bnx2i: CPU %x offline: Remove Rx thread\n",
+			cpu);
 		bnx2i_percpu_thread_destroy(cpu);
 		break;
 	default:
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/