linux-kernel - Re: [PATCH 06/12] 8250: use the 8250 register interface not the legacy one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120627023024.GA13576@kroah.com>
Date:	Tue, 26 Jun 2012 19:30:24 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 06/12] 8250: use the 8250 register interface not the
 legacy one

On Fri, Jun 22, 2012 at 04:43:51PM +0100, Alan Cox wrote:
> @@ -69,7 +69,6 @@ struct uart_port;
>  struct uart_8250_port;
>  
>  int serial8250_register_8250_port(struct uart_8250_port *);
> -int serial8250_register_port(struct uart_port *);

There are still in-kernel callers of this function, so I don't think
it's safe to remove just yet, otherwise the build will break:

drivers/char/mwave/mwavedd.c:   return serial8250_register_port(&uart);
drivers/misc/ibmasm/uart.c:     sp->serial_line = serial8250_register_port(&uport);
drivers/net/ethernet/sgi/ioc3-eth.c:    serial8250_register_port(&port);
drivers/tty/serial/of_serial.c:         ret = serial8250_register_port(&port);

I'm stopping here on this series, I've only applied the one that added
the comment, that seems to be the only one that compiled properly :(

Care to redo these please?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/