linux-kernel - Re: [PATCH 8/8] release memory resources if hotadd_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1206262128140.24245@chino.kir.corp.google.com>
Date:	Tue, 26 Jun 2012 21:29:11 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Wen Congyang <wency@...fujitsu.com>
cc:	lenb@...nel.org, linux-acpi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yasuaki ISIMATU <isimatu.yasuaki@...fujitsu.com>
Subject: Re: [PATCH 8/8] release memory resources if hotadd_new_pgdat()
 failed

On Tue, 26 Jun 2012, Wen Congyang wrote:

> We should goto error to release memory resource if hotadd_new_pgdat() failed.
> 
> Signed-off-by: Wen Congyang <wency@...fujitsu.com>
> ---
>  mm/memory_hotplug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a14d35..3796690 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -617,7 +617,7 @@ int __ref add_memory(int nid, u64 start, u64 size)
>  		pgdat = hotadd_new_pgdat(nid, start);
>  		ret = -ENOMEM;
>  		if (!pgdat)
> -			goto out;
> +			goto error;
>  		new_pgdat = 1;
>  	}
>  

This is a generic memory hotplug patch and doesn't rely on the rest of the 
series, so let's cc the maintainer, Andrew Morton 
<akpm@...ux-foundation.org>.

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/