| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120628060827.19298.14173.stgit@localhost.localdomain>
Date: Thu, 28 Jun 2012 15:08:27 +0900
From: Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>
To: kvm@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
yrl.pp-manager.tt@...achi.com,
Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>,
Avi Kivity <avi@...hat.com>,
Marcelo Tosatti <mtosatti@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>
Subject: [RFC PATCH 13/18] x86/apic: IRQ vector remapping on slave for slave
CPUs
Add a facility to use IRQ vector different from online CPUs on slave CPUs.
When alternative vector for IRQ is registered by remap_slave_vector_irq()
and the IRQ affinity is set only to slave CPUs, the device is configured
to use the alternative vector.
Current patch only supports MSI and Intel CPU with IRQ remapper of IOMMU.
This is intended to be used to routing interrupts directly to KVM guest
which is running on slave CPUs which do not cause VM EXIT by external
interrupts.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>
Cc: Avi Kivity <avi@...hat.com>
Cc: Marcelo Tosatti <mtosatti@...hat.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
---
arch/x86/include/asm/irq.h | 15 ++++++++
arch/x86/kernel/apic/io_apic.c | 68 ++++++++++++++++++++++++++++++++++-
drivers/iommu/intel_irq_remapping.c | 8 +++-
3 files changed, 88 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/irq.h b/arch/x86/include/asm/irq.h
index ba870bb..84756f7 100644
--- a/arch/x86/include/asm/irq.h
+++ b/arch/x86/include/asm/irq.h
@@ -41,4 +41,19 @@ extern int vector_used_by_percpu_irq(unsigned int vector);
extern void init_ISA_irqs(void);
+#ifdef CONFIG_SLAVE_CPU
+extern void remap_slave_vector_irq(int irq, int vector,
+ const struct cpumask *mask);
+extern void revert_slave_vector_irq(int irq, const struct cpumask *mask);
+extern u8 get_remapped_slave_vector(u8 vector, unsigned int irq,
+ const struct cpumask *mask);
+#else
+static inline u8 get_remapped_slave_vector(u8 vector, unsigned int irq,
+ const struct cpumask *mask)
+{
+ return vector;
+}
+#endif
+
+
#endif /* _ASM_X86_IRQ_H */
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 91b3905..916dbf5 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1257,6 +1257,69 @@ void __setup_vector_irq(int cpu)
raw_spin_unlock(&vector_lock);
}
+#ifdef CONFIG_SLAVE_CPU
+
+/* vector table remapped on slave cpus, indexed by IRQ */
+static DEFINE_PER_CPU(u8[NR_IRQS], slave_vector_remap_tbl) = {
+ [0 ... NR_IRQS - 1] = 0,
+};
+
+void remap_slave_vector_irq(int irq, int vector, const struct cpumask *mask)
+{
+ int cpu;
+ unsigned long flags;
+
+ raw_spin_lock_irqsave(&vector_lock, flags);
+ for_each_cpu(cpu, mask) {
+ BUG_ON(!cpu_slave(cpu));
+ per_cpu(slave_vector_remap_tbl, cpu)[irq] = vector;
+ per_cpu(vector_irq, cpu)[vector] = irq;
+ }
+ raw_spin_unlock_irqrestore(&vector_lock, flags);
+}
+EXPORT_SYMBOL_GPL(remap_slave_vector_irq);
+
+void revert_slave_vector_irq(int irq, const struct cpumask *mask)
+{
+ int cpu;
+ u8 vector;
+ unsigned long flags;
+
+ raw_spin_lock_irqsave(&vector_lock, flags);
+ for_each_cpu(cpu, mask) {
+ BUG_ON(!cpu_slave(cpu));
+ vector = per_cpu(slave_vector_remap_tbl, cpu)[irq];
+ if (vector) {
+ per_cpu(vector_irq, cpu)[vector] = -1;
+ per_cpu(slave_vector_remap_tbl, cpu)[irq] = 0;
+ }
+ }
+ raw_spin_unlock_irqrestore(&vector_lock, flags);
+}
+EXPORT_SYMBOL_GPL(revert_slave_vector_irq);
+
+/* If all targets CPUs are slave, returns remapped vector */
+u8 get_remapped_slave_vector(u8 vector, unsigned int irq,
+ const struct cpumask *mask)
+{
+ u8 slave_vector;
+
+ if (vector < FIRST_EXTERNAL_VECTOR ||
+ cpumask_intersects(mask, cpu_online_mask))
+ return vector;
+
+ slave_vector = per_cpu(slave_vector_remap_tbl,
+ cpumask_first(mask))[irq];
+ if (slave_vector >= FIRST_EXTERNAL_VECTOR)
+ vector = slave_vector;
+
+ pr_info("slave vector remap: irq: %d => vector: %d\n", irq, vector);
+
+ return vector;
+}
+
+#endif
+
static struct irq_chip ioapic_chip;
#ifdef CONFIG_X86_32
@@ -3080,6 +3143,7 @@ static int
msi_set_affinity(struct irq_data *data, const struct cpumask *mask, bool force)
{
struct irq_cfg *cfg = data->chip_data;
+ int vector = cfg->vector;
struct msi_msg msg;
unsigned int dest;
@@ -3088,8 +3152,10 @@ msi_set_affinity(struct irq_data *data, const struct cpumask *mask, bool force)
__get_cached_msi_msg(data->msi_desc, &msg);
+ vector = get_remapped_slave_vector(vector, data->irq, mask);
+
msg.data &= ~MSI_DATA_VECTOR_MASK;
- msg.data |= MSI_DATA_VECTOR(cfg->vector);
+ msg.data |= MSI_DATA_VECTOR(vector);
msg.address_lo &= ~MSI_ADDR_DEST_ID_MASK;
msg.address_lo |= MSI_ADDR_DEST_ID(dest);
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index 0045139..2c6f4d3 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -934,9 +934,14 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask,
if (assign_irq_vector(irq, cfg, mask))
return -EBUSY;
+ /* Set affinity to either online cpus only or slave cpus only */
+ cpumask_and(data->affinity, mask, cpu_online_mask);
+ if (unlikely(cpumask_empty(data->affinity)))
+ cpumask_copy(data->affinity, mask);
+
dest = apic->cpu_mask_to_apicid_and(cfg->domain, mask);
- irte.vector = cfg->vector;
+ irte.vector = get_remapped_slave_vector(cfg->vector, irq, mask);
irte.dest_id = IRTE_DEST(dest);
/*
@@ -953,7 +958,6 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask,
if (cfg->move_in_progress)
send_cleanup_vector(cfg);
- cpumask_copy(data->affinity, mask);
return 0;
}
#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists