linux-kernel - Re: [PATCH] i2c-i801: Clear only status bits in HST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jun 2012 14:51:59 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Daniel Kurtz <djkurtz@...omium.org>
Cc:	Ben Dooks <ben-linux@...ff.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Seth Heasley <seth.heasley@...el.com>,
	Olof Johansson <olof@...om.net>,
	Benson Leung <bleung@...omium.org>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c-i801: Clear only status bits in HST_STS after
 waiting for INTR

On Thu, 28 Jun 2012 16:59:30 +0800, Daniel Kurtz wrote:
> Writing back the whole status register could clear unwanted bits.
> In particular, it could clear the "INUSE_STS" bit, which is a
> 'hardware semaphore', that might be useful to use some day.
> To prepare for this, let's ban writing back the whole status to register
> HST_STS, of which this is the only instance.
> 
> Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
> Reported-by: Jean Delvare <khali@...ux-fr.org>
> ---
>  drivers/i2c/busses/i2c-i801.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index ae2945a..7443990 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -301,7 +301,7 @@ static void i801_wait_hwpec(struct i801_priv *priv)
>  	if (timeout > MAX_RETRIES)
>  		dev_dbg(&priv->pci_dev->dev, "PEC Timeout!\n");
>  
> -	outb_p(status, SMBHSTSTS(priv));
> +	outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
>  }
>  
>  static int i801_block_transaction_by_block(struct i801_priv *priv,

Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/