linux-kernel - Re: [PATCH v3] printk: Have printk() never buffer its data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jun 2012 18:48:23 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Kay Sievers <kay@...y.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Joe Perches <joe@...ches.com>,
	"Paul E. McKenney" <paulmck@...ibm.com>
Subject: Re: [PATCH v3] printk: Have printk() never buffer its data

On Thu, Jun 28, 2012 at 09:38:53AM +0200, Kay Sievers wrote:
> On Wed, 2012-06-27 at 11:26 -0400, Kay Sievers wrote:
> > On Wed, Jun 27, 2012 at 11:18 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> > > On Wed, 2012-06-27 at 11:13 -0400, Steven Rostedt wrote:
> > >
> > >> I just tested this patch and it boots fine for me.
> > >
> > > Of course after sending this, I rebooted to the same kernel and it
> > > locked up :-p
> > 
> > Thanks for testing it. Greg had some issues too, which I can't
> > reproduce it on any of my boxes. I'll have a look ...
> 
> Here is an updated version, that should be look a bit cleaner.
> 
> It passes all my tests here, including the fake kernel module that has
> threads racing against each other. With that, the console output gets a
> bit disturbed now without the buffering, but the recorded log still
> looks all fine.

And this solves the boot problem I was seeing, thanks a lot for fixing
that issue.

Steven, any objections to me taking this patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/