linux-kernel - Re: [PATCH] apple-gmux: Correctly depend on apple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340889815.4994.4.camel@localhost>
Date:	Thu, 28 Jun 2012 18:53:35 +0530
From:	Arun Raghavan <arun.raghavan@...labora.co.uk>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apple-gmux: Correctly depend on apple_bl for building

On Thu, 2012-06-28 at 08:20 -0500, Seth Forshee wrote:
> On Thu, Jun 28, 2012 at 04:06:36PM +0530, Arun Raghavan wrote:
> > apple_bl_register/unregister() are unconditionally used now, so we need
> > to make sure that apple_bl is selected appropriately (built-in/module)
> > if apple-gmux is being built.
> 
> apple_bl.h provides stubs for these functions when apple_bl is not
> built, so this shouldn't be necessary. Are you encoutering a situation
> that causes build problems?

Yes, I am. With CONFIG_BACKLIGHT_APPLE=m and CONFIG_APPLE_GMUX=y, I see
the following error:

  LD      init/built-in.o
drivers/built-in.o: In function `gmux_probe':
apple-gmux.c:(.devinit.text+0xa769): undefined reference to `apple_bl_unregister'
drivers/built-in.o: In function `gmux_remove':
apple-gmux.c:(.devexit.text+0x46d): undefined reference to `apple_bl_register'

-- Arun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/