linux-kernel - Re: [PATCH] apple-gmux: Correctly depend on apple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120628151528.GD15308@thinkpad-t410>
Date:	Thu, 28 Jun 2012 10:15:28 -0500
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Arun Raghavan <arun.raghavan@...labora.co.uk>
Cc:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apple-gmux: Correctly depend on apple_bl for building

On Thu, Jun 28, 2012 at 07:21:11PM +0530, Arun Raghavan wrote:
> I missed the stubs, so the patch should probably just be adding this
> line:
> 
> depends on APPLE_BACKLIGHT = n || APPLE_BACKLIGHT
> 
> but that conflicts with the 'select BACKLIGHT_CLASS_DEVICE' (a recursive
> dependency is detected).

Sigh. We have a similar situation with acpi_video, which undoubtedly
also affects some other drivers as well.

This is the best I've been able to come up with.

   depends on BACKLIGHT_CLASS_DEVICE
   depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
   depends on ACPI_VIDEO=n || ACPI_VIDEO

This at least keeps it from being built-in if it's going to be linking
against symbols provided by a module. I'm definitely open to other
suggestions though.

Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/