linux-kernel - Re: [PATCH 01/15] ARM: etm: Don't require clock control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYaOLi7Xrt0MsB1onXCUbb91ZaqngFmFGf3eitrL4Qakg@mail.gmail.com>
Date:	Thu, 28 Jun 2012 17:47:57 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Russell King <linux@....linux.org.uk>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH 01/15] ARM: etm: Don't require clock control

On Thu, Jun 21, 2012 at 12:47 AM, John Stultz <john.stultz@...aro.org> wrote:

> -       clk_enable(t->emu_clk);
> +       else
> +               clk_enable(t->emu_clk);

Take this opportunity to use clk_prepare_enable();

>        etb_unlock(t);
>        t->etb_bufsz = etb_readl(t, ETBR_DEPTH);
> @@ -403,8 +402,10 @@ static int etb_remove(struct amba_device *dev)
>        iounmap(t->etb_regs);
>        t->etb_regs = NULL;
>
> -       clk_disable(t->emu_clk);
> -       clk_put(t->emu_clk);
> +       if (!IS_ERR(t->emu_clk)) {
> +               clk_disable(t->emu_clk);

And clk_disable_uprepare() here.

> +               clk_put(t->emu_clk);
> +       }

After that it's
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/