linux-kernel - Re: [patch] sgi-xp: nested calls to spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120628150342.aaa4ad2d.akpm@linux-foundation.org>
Date:	Thu, 28 Jun 2012 15:03:42 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Robin Holt <holt@....com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Jack Steiner <steiner@....com>
Subject: Re: [patch] sgi-xp: nested calls to spin_lock_irqsave()

On Wed, 27 Jun 2012 08:51:55 -0500
Robin Holt <holt@....com> wrote:

> The code here has a nested spin_lock_irqsave().  It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end.  The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.

Please find large crayon and write on forehead "when fixing a bug,
be sure to describe the end-user impact of that bug".

Then others will have a chance of deciding whether the fix should be
backported.

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Robin Holt <holt@....com>

I'm wondering if there should have been a Reported-by:dan in there. 
He's like that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/