linux-kernel - Re: [PATCH] ubi: fastmap: Do not free 'ai' in 'scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120629132035.1428ca01@spider.haslach.nod.at>
Date:	Fri, 29 Jun 2012 13:20:35 +0200
From:	Richard Weinberger <richard@....at>
To:	Shmulik Ladkani <shmulik.ladkani@...il.com>
Cc:	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	<Heinz.Egger@...utronix.de>, thomas.wucher@...utronix.de,
	tglx@...utronix.de, tim.bird@...sony.com, Marius.Mazarel@...l.ro,
	nyoushchenko@...sta.com, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] ubi: fastmap: Do not free 'ai' in 'scan_all()'

Am Thu, 28 Jun 2012 17:45:46 +0300
schrieb Shmulik Ladkani <shmulik.ladkani@...il.com>:

> From: Shmulik Ladkani <shmulik.ladkani@...il.com>
> 
> Do not call 'destroy_ai(ai)' at error handling of 'scan_all', since:
> - 'ai' is allocated in 'ubi_attach' (the caller of scan_all) and
>   provided as an argument. It's not scan_all's responsibility to free
> it
> - It is not consistent with scan_all's sister function
>   'ubi_attach_fastmap()' which does not free the given 'ai'
> - It will cause a double free as 'ubi_attach' (the caller of scan_all)
>   already destroys 'ai' in case of an error
> 
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
> ---

Applied!

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/