linux-kernel - Re: [PATCH] Staging: android: fix pr_info and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1340987872.6562.47.camel@joe2Laptop>
Date:	Fri, 29 Jun 2012 09:37:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	Pablo Vazquez Rodriguez <peibolvigo@...il.com>
Cc:	greg@...ah.com, swetland@...gle.com, john.stultz@...aro.org,
	arve@...roid.com, ccross@...roid.com, bringert@...roid.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: fix pr_info and pr_err coding style
 issues in ashmem.c

On Fri, 2012-06-29 at 18:27 +0200, Pablo Vazquez Rodriguez wrote:
> This is a patch to the ashmem.c file that fixes up several pr_info and pr_err warnings found by the checkpath.pl tool
[]
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
[]
> @@ -707,7 +707,7 @@ static int __init ashmem_init(void)

Try adding
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any other #include

>  					  sizeof(struct ashmem_area),
>  					  0, 0, NULL);
>  	if (unlikely(!ashmem_area_cachep)) {
> -		printk(KERN_ERR "ashmem: failed to create slab cache\n");
> +		pr_err("ashmem: failed to create slab cache\n");

these then become
		pr_err("failed to create slab cache\n");

> @@ -715,19 +715,19 @@ static int __init ashmem_init(void)
> +		pr_err("ashmem: failed to create slab cache\n");
		pr_err("failed to create slab cache\n");
[]
> +		pr_err("ashmem: failed to register misc device!\n");
		pr_err("failed ...");

etc.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/