linux-kernel - Re: [PATCH] ARM: tegra: apbio: use dmaengine based dma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FEDE035.6040005@wwwdotorg.org>
Date:	Fri, 29 Jun 2012 11:04:53 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	ccross@...roid.com, olof@...om.net, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: tegra: apbio: use dmaengine based dma driver

On 06/29/2012 05:30 AM, Laxman Dewangan wrote:
> Use the dmaengine based Tegra APB DMA driver for
> apbio access in place of legacy Tegra APB DMA.
> 
> The new driver is selected if legacy driver is not
> selected and new DMA driver is enabled through config
> file.

> +bool tegra_apb_dma_init(void)
> +{
...
> +	tegra_apb_dma_chan = dma_request_channel(mask, NULL, NULL);
> +	if (!tegra_apb_dma_chan) {
> +		pr_err("%s: can not allocate dma channel\n", __func__);
> +		goto err_dma_alloc;
> +	}

That fires quite a few times during boot, before the DMA driver is
probed. I think the message should be down-graded to a pr_dbg(). Do you
agree? I can fix that myself when applying this if you're OK with the
change.

Aside from that, this looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/