linux-kernel - Re: [PATCH] vmscan: remove obsolete comment of shrinker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120629223235.GB2079@barrios>
Date:	Sat, 30 Jun 2012 07:32:35 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmscan: remove obsolete comment of shrinker

On Fri, Jun 29, 2012 at 01:15:43PM +0000, Cong Wang wrote:
> 
> On Fri, 29 Jun 2012 at 04:51 GMT, Minchan Kim <minchan@...nel.org> wrote:
> > 09f363c7 fixed shrinker callback returns -1 when nr_to_scan is zero
> > for preventing excessive the slab scanning. But 635697c6 fixed the
> > problem, again so we can freely return -1 although nr_to_scan is zero.
> > So let's revert 09f363c7 because the comment added in 09f363c7 made a
> > unnecessary rule shrinker user should be aware of.
> >
> 
> Please also include the subject of the commit, not just raw hash number. ;)
> 
> For example,
> 
> 09f363c7("vmscan: fix shrinker callback bug in fs/super.c")
> 635697c6("vmscan: fix initial shrinker size handling")

Yeb. It seems akpm handled it by himself.
But I will keep in mind.

Thanks, Cong!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/