lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Jun 2012 16:26:49 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Joe Perches <joe@...ches.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, proski@....org, Andrei Emeltchenko <andrei.emeltchenko@...el.com>, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [RFC][PATCH 1/2] lib: printf: append support of '%*p[Mm][FR]' On Fri, 29 Jun 2012 09:08:06 -0700 Joe Perches <joe@...ches.com> wrote: > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > [] > > @@ -655,11 +655,12 @@ char *resource_string(char *buf, char *end, struct resource *res, > > } > > > > static noinline_for_stack > > -char *mac_address_string(char *buf, char *end, u8 *addr, > > - struct printf_spec spec, const char *fmt) > > +char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec, > > + const char *fmt) > > { > > - char mac_addr[sizeof("xx:xx:xx:xx:xx:xx")]; > > - char *p = mac_addr; > > + char hex_str[64*3]; /* support up to 64 bytes to print */ > > Might be too much stack though. Yes, it's a bit marginal, as this new capability might be used in debug or crash situations where we're deep into the stack. The average case could be improved by using alloca()-style allocation. Documentation/printk-formats.txt would need to be updated please. Also the big comment over vsnprintf(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists