linux-kernel - Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120630064724.GC14083@ZenIV.linux.org.uk>
Date:	Sat, 30 Jun 2012 07:47:24 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Li Zefan <lizefan@...wei.com>
Cc:	"tj@...nel.org" <tj@...nel.org>, shyju pv <shyju.pv@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
	Sanil kumar <sanil.kumar@...wei.com>,
	Masanari Iida <standby24x7@...il.com>
Subject: Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]

On Sat, Jun 30, 2012 at 02:13:02PM +0800, Li Zefan wrote:

> dput will drop both the subdir and the root's dentry refcnt, but kill_sb will be called
> inbetween.

????!!!!??!?!?

> So it's bad to have dentry refcnts dangling after umount.

No shit.  Yes, it is bad.  What on the Earth is cgroup code doing with
those?  And what could it possibly want to do with dentry reference
after the filesystem has been shut down, assuming it could hold one
in the first place?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/