linux-kernel - Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120701182300.GE28922@opensource.wolfsonmicro.com>
Date:	Sun, 1 Jul 2012 19:23:00 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs

On Fri, Jun 29, 2012 at 10:33:15AM -0600, Stephen Warren wrote:

> of_get_named_gpio() needs the driver hosting the GPIO that the DT
> property references to have been probed. Detect this specific failure,
> and defer the probe of the whole regulator until this API can complete.

I've applied this but...

> +	/*
> +	 * of_get_named_gpio() currently returns ENODEV rather than
> +	 * EPROBE_DEFER. This code attempts to be compatible with both
> +	 * for now; the ENODEV check can be removed once the API is fixed.

...this just seems rubbish, why aren't we just fixing the device tree
code and why are we doing this at the device tree level rather than as a
general gpiolib thing?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)