linux-kernel - Re: [PATCH v2 2/3] pwm: Convert pwm-pxa to use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF+7xWnj1cEaUw8HgJ7vf35Ny-aAmoFpj9Q2rOxJ3VnPue0PPg@mail.gmail.com>
Date:	Sun, 1 Jul 2012 17:53:25 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org, Eric Miao <eric.y.miao@...il.com>
Subject: Re: [PATCH v2 2/3] pwm: Convert pwm-pxa to use devm_* APIs

>> -     pwmchip_remove(&chip->chip);
>> -
>> -     iounmap(chip->mmio_base);
>> -
>> -     r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -     release_mem_region(r->start, resource_size(r));
>> -
>> -     clk_put(chip->clk);
>> -     kfree(chip);
>> -     return 0;
>> +     return pwmchip_remove(&chip->chip);
>
> What I meant was that this driver didn't return an error on failure of
> pwmchip_remove() before so incorporating this change is unrelated to
> this patch. Either make it a separate patch (preferably) or at least
> mention it in the commit message.
Oh. I just thought it is a trivial change and it probably ok to do so.
Anyway, Since you prefer having this change in a separate patch,
I'd send a v3 that leave this part unchanged.

Regards,
Axel

>
> Thierry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/