linux-kernel - [PATCH] leds-88pm860x: use the goto label at data->port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1341217332-21153-1-git-send-email-devendra.aaru@gmail.com>
Date:	Mon,  2 Jul 2012 13:52:12 +0530
From:	Devendra Naga <devendra.aaru@...il.com>
To:	Bryan Wu <bryan.wu@...onical.com>,
	Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Devendra Naga <devendra.aaru@...il.com>
Subject: [PATCH] leds-88pm860x: use the goto label at data->port

at the goto lable out: we are doing free of the led data, and returning ret.
the same we are doing at the data->port < 0 case, so use the goto end and
assign ret to -EINVAL. this will make the common err path for the
data->port and led_classdev_register functions.

Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
---
 drivers/leds/leds-88pm860x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 5b61aaf..538aaa3 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -220,8 +220,8 @@ static int pm860x_led_probe(struct platform_device *pdev)
 	data->port = pdata->flags;
 	if (data->port < 0) {
 		dev_err(&pdev->dev, "check device failed\n");
-		kfree(data);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto out;
 	}
 
 	data->current_brightness = 0;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/