linux-kernel - Re: [PATCH 2/2] ASoC: tegra: use sound pcm library for substream dma buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120702095606.GB25093@opensource.wolfsonmicro.com>
Date:	Mon, 2 Jul 2012 10:56:06 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, lrg@...com,
	lars@...afoo.de, swarren@...dia.com, perex@...ex.cz,
	clemens@...isch.de, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: tegra: use sound pcm library for substream dma
 buffer

On Mon, Jul 02, 2012 at 11:14:55AM +0200, Takashi Iwai wrote:
> Laxman Dewangan wrote:

> > -	if (!card->dev->dma_mask)
> > -		card->dev->dma_mask = &tegra_dma_mask;
> > -	if (!card->dev->coherent_dma_mask)
> > -		card->dev->coherent_dma_mask = DMA_BIT_MASK(32);

> The mask setup is still required even if you use the preallocation
> helper.

Though that code is at least notionally buggy anyway, it should be the
DMA controller device that's used to obtain the DMA mask rather than the
card device which is basically unconnected with DMA.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)