linux-kernel - Re: [PATCH] fat: Refactor shortname parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8762a6nsao.fsf@devron.myhome.or.jp>
Date:	Mon, 02 Jul 2012 23:36:47 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	"Steven J. Magnani" <steve@...idescorp.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: Refactor shortname parsing

"Steven J. Magnani" <steve@...idescorp.com> writes:

> True, but with the change you suggest we lose the incrementing of 'i',
> which likely would cause an infinite loop for 1:1 Unicode conversions.

You meant, we just have to do

	if (!is_vfat)
        	ptname[i] = ...;
	i++;

or something? I still feel this looks better to indicate, we don't use
ptname in the case of vfat.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/