linux-kernel - Re: [PATCH] fat: Refactor shortname parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87txxqm756.fsf@devron.myhome.or.jp>
Date:	Tue, 03 Jul 2012 01:59:01 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	"Steven J. Magnani" <steve@...idescorp.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: Refactor shortname parsing

"Steven J. Magnani" <steve@...idescorp.com> writes:

>> Hm, the primary case is vfat. fat_tolower()/hidden is required only for
>> msdos, and ptname too. So, my suggestion is trying to keep vfat case
>> clean.
>
> It's not clear to me where you want to go with this. 
>
> 1. Split fat_parse_short() into msdos and vfat versions. This may
> improve clarity, but there would be some replication of code.

This is not a option. We are better to not change.

> 2. Sprinkle "if (!isvfat)" throughout the already-proposed version of
> fat_parse_short()
>   A. Everywhere
>   B. Only in the places you've proposed

I'm not sure what (A) means though. Probably, I will not care.

> 3. Retain the already-proposed version of fat_parse_short(), but add a
> comment that the uni_name overrides the msdos "ptname", and separate out
> the decision to lowercase from fat_tolower() [i.e., the trigraph].

The trigraph change doesn't cleanup anything. Because it is using
needless ptname on vfat path.

vfat always uses the uni_name and doesn't use ptname, right?  And msdos
path doesn't use the uni_name and use ptname always.  So, I'm saying,
let's make clear those difference and usage, by annotating with isvfat.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/