linux-kernel - Re: [PATCH] mm: setup pageblock_order before it's used by sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXpeGFfWvUHHW_GjgTg+4Op7agsht5coZbcmn2W=f9bqw@mail.gmail.com>
Date:	Mon, 2 Jul 2012 13:43:22 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jiang Liu <jiang.liu@...wei.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Tony Luck <tony.luck@...el.com>,
	Xishi Qiu <qiuxishi@...wei.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	David Rientjes <rientjes@...gle.com>,
	Minchan Kim <minchan@...nel.org>,
	Keping Chen <chenkeping@...wei.com>, linux-mm@...ck.org,
	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jiang Liu <liuj97@...il.com>
Subject: Re: [PATCH] mm: setup pageblock_order before it's used by sparse

On Sun, Jul 1, 2012 at 7:01 PM, Jiang Liu <jiang.liu@...wei.com> wrote:
> Hi Yinghai,
>         The patch fails compilation as below:
> mm/page_alloc.c:151: error: initializer element is not constant
> mm/page_alloc.c:151: error: expected ‘,’ or ‘;’ before ‘__attribute__’
>
> On IA64, HUGETLB_PAGE_ORDER has dependency on variable hpage_shift.
> # define HUGETLB_PAGE_ORDER        (HPAGE_SHIFT - PAGE_SHIFT)
> # define HPAGE_SHIFT               hpage_shift
>
> And hpage_shift could be changed by early parameter "hugepagesz".
> So seems will still need to keep function set_pageblock_order().

ah,  then use use _DEFAULT instead and later could update that in earlyparam.

So attached -v2 should  work.

Thanks

Yinghai

Download attachment "kill_set_pageblock_order_v2.patch" of type "application/octet-stream" (3159 bytes)