linux-kernel - Re: [PATCH] SCSI: Add SG_GET_SG_MAX_SEGMENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341302003.17396.20.camel@mengcong>
Date:	Tue, 03 Jul 2012 15:53:23 +0800
From:	Cong Meng <mc@...ux.vnet.ibm.com>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	stefanha@...ux.vnet.ibm.com, linuxram@...ibm.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	senwang@...ux.vnet.ibm.com
Subject: Re: [PATCH] SCSI: Add SG_GET_SG_MAX_SEGMENT_SIZE ioctl to sg device

On Mon, 2012-07-02 at 12:18 +0100, James Bottomley wrote:
> On Mon, 2012-07-02 at 17:20 +0800, Cong Meng wrote:
> > Add a new ioctl cmd to get the max segment size. It's useful in
> > virtualization environment for guest to know the queue limits, so
> > that the guest kicks off legal scsi command to a sg device.
> 
> What's wrong with simply looking in the /sys for this? Plus, if you can

Adding this ioctl is a big convenience for the programs, qemu 
in my case, to which parameter that likes '/dev/sgX' is given. 
With this ioctl, those programs only need to issue an ioctl to 
get the queue limit. Otherwise, 'dev/sgX' is needed to convert 
to /sys path, then open and read it. 
In addition, the potential variation and exceptional situation 
of sys FS, EX mount path, are needed to consider as well.
Is my justification acceptable? 

> come up with a justifiable reason, this needs to be in block as well so
> we can send it to all SCSI devices regardless of what ULD people use.
I can do it.

Thanks.
Cong.
> 
> James
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/