linux-kernel - [PATCH] misc: mei: set IRQF_ONESHOT for MSI request_threaded_irq() in mei_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1341306510-28808-1-git-send-email-roland@kernel.org>
Date:	Tue,  3 Jul 2012 02:08:30 -0700
From:	Roland Dreier <roland@...nel.org>
To:	Tomas Winkler <tomas.winkler@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lekensteyn <lekensteyn@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] misc: mei: set IRQF_ONESHOT for MSI request_threaded_irq() in mei_pci_resume()

From: Roland Dreier <roland@...estorage.com>

When the default quick IRQ handler is used then IRQF_ONESHOT must be set,
or else the request fails and following error is logged on resume:

    genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq ...

This is the same fix that commit aa189ecdc0c7 ("misc: mei: set
IRQF_ONESHOT for msi request_threaded_irq") did in the probe function.

Reported-by: Lekensteyn <lekensteyn@...il.com>
Signed-off-by: Roland Dreier <roland@...estorage.com>
---
Can you try this?  It looks to be needed.

Thomas/Greg, I think this should get into 3.5 if possible.

 drivers/misc/mei/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 7de1389..783fcd7 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -1147,7 +1147,7 @@ static int mei_pci_resume(struct device *device)
 		err = request_threaded_irq(pdev->irq,
 			NULL,
 			mei_interrupt_thread_handler,
-			0, mei_driver_name, dev);
+			IRQF_ONESHOT, mei_driver_name, dev);
 	else
 		err = request_threaded_irq(pdev->irq,
 			mei_interrupt_quick_handler,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/