lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Tue,  3 Jul 2012 17:08:34 +0800
From:	Xiaoguang Chen <chenxg@...vell.com>
To:	linux-kernel@...r.kernel.org
Cc:	myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
	mturquette@...com, axel.lin@...il.com,
	Xiaoguang Chen <chenxg@...vell.com>
Subject: [PATCH] PM: Devfreq: fix userspace governor frequency bug

The frequency set by userspace governor may not the
same as the final frequency. If this condition happens,
then "cat set_freq" will return a wrong value which is
inconsistant with the real frequency.

This patch updates data->user_frequency after calling
of update_devfreq. use devfreq->revious_freq as the
final user_frequency.

Signed-off-by: Xiaoguang Chen <chenxg@...vell.com>
---
 drivers/devfreq/governor_userspace.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
index 0681246..85ad80a 100644
--- a/drivers/devfreq/governor_userspace.c
+++ b/drivers/devfreq/governor_userspace.c
@@ -59,6 +59,7 @@ static ssize_t store_freq(struct device *dev, struct device_attribute *attr,
 	err = update_devfreq(devfreq);
 	if (err == 0)
 		err = count;
+	data->user_frequency = devfreq->previous_freq;
 	mutex_unlock(&devfreq->lock);
 	return err;
 }
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ