linux-kernel - Re: [PATCH v2] regulator: ad5398: Fix min/max current limit boundary checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF+7xWk5qQa5nV3OdFM51U1Kh7g9w3dA5mLL+SGRQ7_AFNkp5A@mail.gmail.com>
Date:	Tue, 3 Jul 2012 17:44:15 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	"Zhang, Sonic" <Sonic.Zhang@...log.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH v2] regulator: ad5398: Fix min/max current limit boundary checking

>>As long as it is smaller than the maximum requested current, yes. You
>>request a current range with the regulator API and any value within this
>>range is fine as the actual output current.
>>
>
> If so, please also set the max_uA as well.

The equation to calculate the selector does not depend on max_uA.
So I think we don't need to set the requested max_uA.

Current does check the selected current by:
if (ad5398_calc_current(chip, selector) > max_uA)
        return -EINVAL;

This ensures the selected current falls within specified range.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/