linux-kernel - Re: [PATCH -v2 1/2] x86, microcode: Sanitize per-cpu microcode reloading interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120703104135.GA12820@aftab.osrc.amd.com>
Date:	Tue, 3 Jul 2012 12:41:35 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	X86-ML <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH -v2 1/2] x86, microcode: Sanitize per-cpu microcode
 reloading interface

On Tue, Jul 03, 2012 at 11:26:08AM +0200, Peter Zijlstra wrote:
> On Tue, 2012-07-03 at 06:37 +0200, Borislav Petkov wrote:
> > In thinking about this a bit more, perf callback is only run from the
> > reload_store interface but we don't run it on module init time. 
> 
> @@ -557,7 +560,8 @@ static int __init microcode_init(void)
>         mutex_lock(&microcode_mutex);
> 
>         error = subsys_interface_register(&mc_cpu_interface);
> -
> +       if (!error)
> +               perf_check_microcode();
>         mutex_unlock(&microcode_mutex);
>         put_online_cpus();
> 
> 
> I thought that was init time?

Doh, I'm blind, sorry :-/

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/