| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120703140048.GC11272@redhat.com> Date: Tue, 3 Jul 2012 10:00:48 -0400 From: Vivek Goyal <vgoyal@...hat.com> To: Paolo Bonzini <pbonzini@...hat.com> Cc: linux-kernel@...r.kernel.org, axboe@...nel.dk, snitzer@...hat.com, martin.petersen@...cle.com, david@...morbit.com, xfs@....sgi.com, dm-devel@...hat.com, hch@....de Subject: Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment On Tue, Jul 03, 2012 at 01:51:13PM +0200, Paolo Bonzini wrote: > Il 03/07/2012 04:34, Vivek Goyal ha scritto: > >> > The next patches will actually use the alignment, expose it in sysfs > >> > for ease of debugging. > >> > > > Don't we already have discard_alignment exported as device attribute. > > > > /sys/block/<dev>/discard_alignment > > Ah, interesting, I missed it completely. I guess it's because queue/ > directories only exist for full disks, and the correct alignment varies > for each partition. So this patch is unnecessary. Partition discard_alignments are available in /sys/block/<disk>/<partition>/discard_alignment. That raises an interesting question for patch3. If the discard is happening to a partition, shouldn't you be looking at partition discard_alignment instead of always looking at queue discard_alignment? Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists