linux-kernel - Re: [PATCH 1/1] usb: gadget: s3c-hsotg: fix core reset timeout failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FF329F5.6000801@mvista.com>
Date:	Tue, 03 Jul 2012 21:20:53 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	"Du, Changbin" <changbin.du@...il.com>
CC:	balbi@...com, gregkh@...uxfoundation.org, ben@...tec.co.uk,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: s3c-hsotg: fix core reset timeout failure

Hello.

On 07/03/2012 06:03 AM, Du, Changbin wrote:

> The timeout values were 1000 and timeout issue occured many times on my
> s3c6410 Soc based board (mostly when booting whith USB cable not
> connected). This patch increase the values to 10000 to guarantee the
> success of reset.

> Having set timeout to 10000, I printed the remained timeout values
> which can cause timeout issue before this change (tested several times):
> the first timeout value remained:
> 	timeout = 8079
> 	timeout = 8079
> 	timeout = 8078
> 	timeout = 8081
> the second timeout value remained:
> 	timeout = 7940
> 	timeout = 7945
> 	timeout = 7940
> 	timeout = 7938
> Seeing from above values, I think 10000 is big enough.

> Signed-off-by: Du, Changbin <changbin.du@...il.com>
> ---
>  drivers/usb/gadget/s3c-hsotg.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index f4abb0e..f3e2234 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -2215,7 +2215,7 @@ static int s3c_hsotg_corereset(struct s3c_hsotg
> *hsotg)

  Your patch is line wrapped; seems easy to fix manually while applying though...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/