linux-kernel - Re: [PATCH 2/2] regulator: fixed: dt: support for input supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120703191704.GE29030@opensource.wolfsonmicro.com>
Date:	Tue, 3 Jul 2012 20:17:05 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lrg@...com, grant.likely@...retlab.ca, rob.herring@...xeda.com,
	rob@...dley.net, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: fixed: dt: support for input supply

On Mon, Jul 02, 2012 at 03:37:25PM +0530, Laxman Dewangan wrote:

> +	if (vin_supply)
> +		drvdata->desc.supply_name = "vin";
> +

This isn't great both in terms of it being conditional and the fact that
it's only usable on DT systems as there's no non-DT way to do this.  In
general unless we're working around some device tree issue (which should
be *very* rare) we shouldn't be adding any DT only stuff to generic
code, we need to be able to run Linux on non-DT systems.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)