linux-kernel - Re: md: fix up plugging (again). breaks build of the latest 3.5rc5+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120704094133.3f58fcf1@notabene.brown>
Date:	Wed, 4 Jul 2012 09:41:33 +1000
From:	NeilBrown <neilb@...e.de>
To:	Tobias Klausmann <tobias.johannes.klausmann@....thm.de>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: md: fix up plugging (again). breaks build of the latest 3.5rc5+

On Tue, 03 Jul 2012 23:42:10 +0200 Tobias Klausmann
<tobias.johannes.klausmann@....thm.de> wrote:

> Proposing this patch:
> 
> >From c6ac2740ed916ccf5b6fec0682101dd7a6a50f9f Mon Sep 17 00:00:00 2001
> From: Tobias Klausmann <tobias.klausmann@....thm.de>
> Date: Tue, 3 Jul 2012 23:03:43 +0200
> Subject: [PATCH] Fix patch md: fix up plugging again. Commit
>  b357f04a67c2aeee828b240863cd3f21d6cb3179
> 
> ---
>  drivers/md/raid10.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index acf5a82..8da6282 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1394,7 +1394,7 @@ retry_write:
>  		bio_list_add(&conf->pending_bio_list, mbio);
>  		conf->pending_count++;
>  		spin_unlock_irqrestore(&conf->device_lock, flags);
> -		if (!mddev_check_plugged(mddev, 0, 0))
> +		if (!mddev_check_plugged(mddev))
>  			md_wakeup_thread(mddev->thread);
> 
>  		if (!r10_bio->devs[i].repl_bio)

Thanks.  That was careless.
I've posted a pull request so Linus can take either that or this.

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)