linux-kernel - Re: [PATCH] dma: imx-dma: Fix kernel crash due to missing clock conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120704070638.GI2698@pengutronix.de>
Date:	Wed, 4 Jul 2012 09:06:38 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	vinod.koul@...el.com, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, dan.j.williams@...el.com,
	javier.martin@...ta-silicon.com, Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] dma: imx-dma: Fix kernel crash due to missing clock
 conversion

On Tue, Jul 03, 2012 at 03:33:29PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@...il.com>
> 
> With the new i.MX clock infrastructure we need to request the dma clocks
> seperately: ahb and ipg clocks.
> 
> This fixes the following kernel crash and make audio to be functional again:
> 
> 
> Reported-by: Javier Martin <javier.martin@...ta-silicon.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

One minor comment inside, should you have to resend this, please
consider addressing it. Otherwise:

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>

> ---
>  drivers/dma/imx-dma.c |   36 +++++++++++++++++++++++++-----------
>  1 files changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index fcfeb3c..5084975 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -172,7 +172,8 @@ struct imxdma_engine {
>  	struct device_dma_parameters	dma_parms;
>  	struct dma_device		dma_device;
>  	void __iomem			*base;
> -	struct clk			*dma_clk;
> +	struct clk			*dma_ahb;
> +	struct clk			*dma_ipg;

I would prefer the names 'clk_*' so that it's a bit more obvious what
these are.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/