linux-kernel - [PATCH] init: Fix erroneous printed check in calibrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1341387143-3338-1-git-send-email-jouni.hogander@intel.com>
Date:	Wed,  4 Jul 2012 10:32:23 +0300
From:	Jouni Hogander <jouni.hogander@...el.com>
To:	linux-kernel@...r.kernel.org
Cc:	jouni.hogander@...el.com, illyas.mansoor@...el.com,
	ilkka.koskinen@...el.com
Subject: [PATCH] init: Fix erroneous printed check in calibrate_delay

Calibration is skipped only on first calibrate_delay when it's done
using timer. This is causing unnecessary delay when CPU is hotplugged
in.

Signed-off-by: Jouni Hogander <jouni.hogander@...el.com>
Reviewed-by: Ilkka Koskinen <ilkka.koskinen@...el.com>
Reviewed-by: Illyas Mansoor <illyas.mansoor@...el.com>
---
 init/calibrate.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/init/calibrate.c b/init/calibrate.c
index fda0a7b..b7dcaf9 100644
--- a/init/calibrate.c
+++ b/init/calibrate.c
@@ -275,10 +275,11 @@ void __cpuinit calibrate_delay(void)
 		if (!printed)
 			pr_info("Calibrating delay loop (skipped) "
 				"preset value.. ");
-	} else if ((!printed) && lpj_fine) {
+	} else if (lpj_fine) {
 		lpj = lpj_fine;
-		pr_info("Calibrating delay loop (skipped), "
-			"value calculated using timer frequency.. ");
+		if (!printed)
+			pr_info("Calibrating delay loop (skipped), "
+				"value calculated using timer frequency.. ");
 	} else if ((lpj = calibrate_delay_is_known())) {
 		;
 	} else if ((lpj = calibrate_delay_direct()) != 0) {
-- 
1.7.4.1
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/