[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1341397848.2507.93.camel@laptop>
Date: Wed, 04 Jul 2012 12:30:48 +0200
From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
To: Jiri Olsa <jolsa@...hat.com>
Cc: acme@...hat.com, mingo@...e.hu, paulus@...ba.org,
cjashfor@...ux.vnet.ibm.com, fweisbec@...il.com,
eranian@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] perf, tool: Fix pmu object initialization
On Wed, 2012-07-04 at 00:00 +0200, Jiri Olsa wrote:
> The internal pmu list was never used. With each perf_pmu__find() call
> the pmu structure was created new by parsing sysfs. Beside this it
> caused memory leaks. We now keep all pmus by adding them to the list.
>
> Also, pmu_lookup() should return pmus that do not expose the format
> specifier in sysfs.
>
> We need a valid internal pmu list in a later patch to iterate over all
> pmus that exist in the system.
>
> Signed-off-by: Robert Richter <robert.richter@....com>
> [ added same treatment for 'event' sysfs group attribute ]
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
Are we missing a From: ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists