linux-kernel - Re: [PATCH] printk: fixing the deadlock when calling printk in nmi handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341408169.2507.111.camel@laptop>
Date:	Wed, 04 Jul 2012 15:22:49 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
Cc:	"'linux-kernel@...r.kernel.org' (linux-kernel@...r.kernel.org)" 
	<linux-kernel@...r.kernel.org>, "kay@...y.org" <kay@...y.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"mingo@...e.hu" <mingo@...e.hu>
Subject: Re: [PATCH] printk: fixing the deadlock when calling printk in nmi
 handle

On Wed, 2012-07-04 at 13:00 +0000, Liu, Chuansheng wrote:
> From: liu chuansheng <chuansheng.liu@...el.com>
> Subject: [PATCH] printk: fixing the deadlock when calling printk in nmi handle
> 
> Current printk implementation can not fully support that
> calling it in nmi handler for SMP arch.
> 
> There is typical case in nmi handler function arch_trigger_all_cpu_backtrace_handler().
> 
> In my platform, there are 2 CPUs, when function arch_trigger_all_cpu_backtrace()
> is called, 2 CPUs will recevied the nmi interrupts, and the
> arch_trigger_all_cpu_backtrace_handler() will called on 2 CPUs:
> 
> case1:
> CPU0                                            CPU1
> calling arch_trigger_all_cpu_backtrace()        calling printk, and has obtain the logbuf_lock
> nmi interrupt received                          nmi interrupt received
> call arch_trigger_all_cpu_backtrace_handler()   call arch_trigger_all_cpu_backtrace_handler()
> Obtain arch_spin_lock(&lock);                   Waiting for arch_spin_lock(&lock);
> Continue to call printk()
> CPU0 will be blocked by logbuf_lock             CPU1 is blocked by arch_spin_lock(&lock)
> 
> The deadlock will be happening.
> 
> case2:
> CPU0                                             CPU1:(run dmesg command)
> calling arch_trigger_all_cpu_backtrace()         calling do_syslog
>                                                  Obtaining the logbuf_lock
> nmi interrupt received                           nmi interrupt received
> ....
> The dealock will happen also somtimes.
> 
> I just write a simple interface to run the arch_trigger_all_cpu_backtrace_handler() every 5s,
> it will trigger dead lock many times.
> 
> The solution is when printk is called in nmi handler, we will use trylock instead of lock.
> And in nmi handler, do the call the console write function because normal console write function
> include many spin locks also. This fix can confirm the traces in nmi handler can be output successfully
> almost.
> 
> Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>


Yuck.. and no. This makes sane things like early 8250 serial console
less reliable.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/