linux-kernel - [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1341412376-6272-1-git-send-email-will.deacon@arm.com>
Date:	Wed,  4 Jul 2012 15:32:56 +0100
From:	Will Deacon <will.deacon@....com>
To:	linux-mm@...ck.org
Cc:	akpm@...ux-foundation.org, dhillf@...il.com, mhocko@...e.cz,
	linux-kernel@...r.kernel.org, Will Deacon <will.deacon@....com>
Subject: [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace

When allocating and returning clear huge pages to userspace as a
response to a fault, we may zero and return a mapping to a previously
dirtied physical region (for example, it may have been written by
a private mapping which was freed as a result of an ftruncate on the
backing file). On architectures with Harvard caches, this can lead to
I/D inconsistency since the zeroed view may not be visible to the
instruction stream.

This patch solves the problem by flushing the region after allocating
and clearing a new huge page. Note that PowerPC avoids this issue by
performing the flushing in their clear_user_page implementation to keep
the loader happy, however this is closely tied to the semantics of the
PG_arch_1 page flag which is architecture-specific.

Acked-by: Catalin Marinas <catalin.marinas@....com>
Signed-off-by: Will Deacon <will.deacon@....com>
---
 mm/hugetlb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index e198831..b83d026 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2646,6 +2646,7 @@ retry:
 			goto out;
 		}
 		clear_huge_page(page, address, pages_per_huge_page(h));
+		flush_dcache_page(page);
 		__SetPageUptodate(page);

 		if (vma->vm_flags & VM_MAYSHARE) {
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/