lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Jul 2012 00:12:03 -0400 From: "Zhang, Sonic" <Sonic.Zhang@...log.com> To: Axel Lin <axel.lin@...il.com>, Mark Brown <broonie@...nsource.wolfsonmicro.com> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Lars-Peter Clausen <lars@...afoo.de>, Liam Girdwood <lrg@...com> Subject: RE: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary checking Acked-by: Sonic Zhang <sonic.zhang@...log.com> >-----Original Message----- >From: Axel Lin [mailto:axel.lin@...il.com] >Sent: Wednesday, July 04, 2012 11:55 AM >To: Mark Brown >Cc: linux-kernel@...r.kernel.org; Zhang, Sonic; Lars-Peter Clausen; Liam >Girdwood >Subject: [PATCH v3] regulator: ad5398: Fix min/max current limit boundary >checking > >It is ok to request current limit with min_uA < chip->min_uA and >max_uA > chip->max_uA. > >We need to set min_uA = chip->min_uA if (min_uA < chip->min_uA), >this ensures the equation to calcuate selator does not return negative number. > >Also set max_uA = chip->max_uA if (max_uA > chip->max_uA), as suggested by >Sonic. > >Signed-off-by: Axel Lin <axel.lin@...il.com> >--- > drivers/regulator/ad5398.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c >index 46d05f3..f123f7e 100644 >--- a/drivers/regulator/ad5398.c >+++ b/drivers/regulator/ad5398.c >@@ -89,9 +89,12 @@ static int ad5398_set_current_limit(struct regulator_dev >*rdev, int min_uA, int > unsigned short data; > int ret; > >- if (min_uA > chip->max_uA || min_uA < chip->min_uA) >- return -EINVAL; >- if (max_uA > chip->max_uA || max_uA < chip->min_uA) >+ if (min_uA < chip->min_uA) >+ min_uA = chip->min_uA; >+ if (max_uA > chip->max_uA) >+ max_uA = chip->max_uA; >+ >+ if (min_uA > chip->max_uA || max_uA < chip->min_uA) > return -EINVAL; > > selector = DIV_ROUND_UP((min_uA - chip->min_uA) * chip->current_level, >-- >1.7.9.5 > > >
Powered by blists - more mailing lists