linux-kernel - Re: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jul 2012 11:17:36 +0530
From:	"ABRAHAM, KISHON VIJAY" <kishon@...com>
To:	"Matcovschi, Oleg" <oleg.matcovschi@...com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"Balbi, Felipe" <balbi@...com>
Subject: Re: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events

Hi Oleg,

On Tue, Jul 3, 2012 at 11:09 PM, Matcovschi, Oleg
<oleg.matcovschi@...com> wrote:
>>From: linux-omap-owner@...r.kernel.org [linux-omap-owner@...r.kernel.org] on behalf of ABRAHAM, KISHON VIJAY
>>Sent: Friday, June 22, 2012 5:10 AM
>>To: gregkh@...uxfoundation.org; ABRAHAM, KISHON VIJAY; linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org; Balbi, Felipe
>>Subject: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events
>
>>The atomic notifier from twl4030/twl6030 to notifiy VBUS and ID events,
>>is replaced by a direct call to omap musb blue.
>
>>Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>>---
>> drivers/usb/musb/omap2430.c   |   94 +++++++++++++++++++++++++---------------
>> drivers/usb/otg/twl4030-usb.c |   46 ++++++++++----------
>> drivers/usb/otg/twl6030-usb.c |   47 +++++++++-----------
>> include/linux/usb/musb-omap.h |   30 +++++++++++++
>> 4 files changed, 133 insertions(+), 84 deletions(-)
>> create mode 100644 include/linux/usb/musb-omap.h
> .....
> +enum omap_musb_vbus_id_status {
> +       OMAP_MUSB_UNKNOWN = 0,
> +       OMAP_MUSB_ID_GROUND,
> +       OMAP_MUSB_ID_FLOAT,
> +       OMAP_MUSB_VBUS_VALID,
> +       OMAP_MUSB_VBUS_OFF,
> +};
> +
>
> Why did you choose to introduce OMAP_MUSB specific VBUS, ID events?
> IMHO, it makes more sense to introduce mailbox functionality only without extra translation layer.
> Same mailbox glue layer could be used for other PHY drivers, not just twl.

We've decided to make twl as a comparator driver since we have a
separate phy driver (not yet merged). Hence we dint want twl to use
usb_phy specific events. So if you have other PHY drivers, you can
still use the OMAP_MUSB specific events.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/