linux-kernel - Re: [PATCH] lib/kobject: simplify function kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpU-RTQWxRr1p7WNn4Homz9eitOeOQuB120cdhawOjZDJA@mail.gmail.com>
Date:	Thu, 5 Jul 2012 23:01:20 +0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Dong Hao <haodong@...ux.vnet.ibm.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/kobject: simplify function kobject_init

On Thu, Jul 5, 2012 at 3:58 PM, Dong Hao <haodong@...ux.vnet.ibm.com> wrote:
>         if (kobj->state_initialized) {
>                 /* do not error out as sometimes we can recover */
> -               printk(KERN_ERR "kobject (%p): tried to init an initialized "
> -                      "object, something is seriously wrong.\n", kobj);
> -               dump_stack();
> +               err_str = "tried to init an initialized object, something is seriously wrong.";
> +               goto error;

You missed the comment:

   /* do not error out as sometimes we can recover */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/