linux-kernel - [PATCH v3 0/2] block: improvements for discard alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu,  5 Jul 2012 18:01:42 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	snitzer@...hat.com, david@...morbit.com, dm-devel@...hat.com,
	xfs@....sgi.com, hch@....de, martin.petersen@...cle.com,
	axboe@...nel.dk, vgoyal@...hat.com
Subject: [PATCH v3 0/2] block: improvements for discard alignment

When a disk has a large discard_granularity, discards are not split with
optimal alignment; the pessimization gets bigger as discard_granularity
and max_discard_sectors become closer.

Take the limit case of discard_granularity == max_discard_sectors == 64.
Then, if a request is submitted for 256 sectors 2..257 it will be split
like this: 2..65, 66..129, 130..193, 194..257.  None of these requests
is aligned, so in fact you might end up with no discarded logical blocks
at all.  With this patch, the split will be 2..63, 64..127, 128..191,
192..255, 256..257.  The patches also take the discard_alignment into
consideration.

Patch 1 adjusts the computation of the granularity-adjusted
max_discard_sectors so that it prepares for the new code in patch 2,
which actually adjusts the split.

v2->v3: drop addition of queue/discard_alignment to sysfs, use
  correct alignment for partitions

Paolo Bonzini (2):
  block: reorganize rounding of max_discard_sectors
  block: split discard into aligned requests

 block/blk-lib.c        |   41 ++++++++++++++++++++++++++++-------------
 include/linux/blkdev.h |   10 ++++++++++
 2 files changed, 38 insertions(+), 13 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/