linux-kernel - Re: [PATCH 2/2] sunrpc/cache.h: replace simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120705191323.GA3051@fieldses.org>
Date:	Thu, 5 Jul 2012 15:13:24 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Eldad Zack <eldad@...refinery.com>
Cc:	Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] sunrpc/cache.h: replace simple_strtoul

On Thu, Jul 05, 2012 at 09:04:03PM +0200, Eldad Zack wrote:
> 
> On Wed, 4 Jul 2012, J. Bruce Fields wrote:
> > On Thu, Jul 05, 2012 at 01:00:26AM +0200, Eldad Zack wrote:
> > > This patch replaces the usage of simple_strtoul with kstrtoint in
> > > get_int().
> > 
> > Why?
> 
> Since the simple_str* family don't account for overflow and AFAIK
> deprecated. Also, in this specific case, the long from strtol is 
> silently converted to an int by the caller.

OK, thanks.  Please use that as the changelog when you resend.  ("This
patch replaces..." tells me nothing I couldn't figure out from looking
at the patch.)

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/