linux-kernel - Re: [PATCH v2 2/2] ata: implement MODE SELECT command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FF5EE29.6020706@mvista.com>
Date:	Thu, 05 Jul 2012 23:42:33 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
CC:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>
Subject: Re: [PATCH v2 2/2] ata: implement MODE SELECT command

Hello.

On 07/05/2012 04:05 PM, Paolo Bonzini wrote:

>>> +
>>> +    /*
>>> +     * No mode subpages supported (yet) but asking for _all_
>>> +     * subpages may be valid
>>> +     */
>>> +    if (spg && (spg != ALL_SUB_MPAGES))
>>> +        goto invalid_param;

>>    Rather "paramater not supported" (0x26/0x01)...

> SCSI spec begs to differ... there is no reference to that sense code in
> the whole SPC spec.

   Right you are, I was just picking the more fitting ASC/ASCQ from the table
instead of reading the command description itself. :-<

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/