linux-kernel - Re: [PATCH 5/6] ftrace/x86: Add separate function to save regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341520640.21574.19.camel@gandalf.stny.rr.com>
Date:	Thu, 05 Jul 2012 16:37:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Alexander van Heukelum <heukelum@...tmail.fm>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 5/6] ftrace/x86: Add separate function to save regs

On Tue, 2012-07-03 at 18:54 +0200, Alexander van Heukelum wrote:
> On Mon, Jul 2, 2012, at 16:03, Steven Rostedt wrote:
> > Email had 1 attachment:
> > + 0005-ftrace-x86-Add-separate-function-to-save-regs.patch
> >   23k (text/plain)
> 
> Hi Steven,
> 
> One thing that caught my eye...
> 
> > diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> > index e3e17a0..acd4963 100644
> > --- a/arch/x86/kernel/entry_32.S
> > +++ b/arch/x86/kernel/entry_32.S
> > @@ -1109,6 +1109,7 @@ ENTRY(ftrace_caller)
> >  	pushl %eax
> >  	pushl %ecx
> >  	pushl %edx
> > +	pushl $0	/* Pass NULL as regs pointer */
> >  	movl 0xc(%esp), %eax
> 
> This should now be changed to "0x10(%esp)", right?

Yeah, I think you're right. Actually, I think I originally had it as:

	movl 0xc(%esp), %eax
+	pushl $0

But after a few other changes, it went to this. I haven't finished
testing against x86_64, and haven't started the i386 tests. I'm sure
this would have blown up then ;-)

Thanks,

-- Steve


> 
> Greetings,
>     Alexander
> 
> >  	movl 0x4(%ebp), %edx
> >  	leal function_trace_op, %ecx
> > @@ -1118,6 +1119,7 @@ ENTRY(ftrace_caller)
> >  ftrace_call:
> >  	call ftrace_stub
> >  
> > +	addl $4,%esp	/* skip NULL pointer */
> >  	popl %edx
> >  	popl %ecx
> >  	popl %eax


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/