linux-kernel - Re: [PATCH 1/1] ACL: increase the #define XFS_ACL_MAX_ENTRIES to 128 The xfsprogs xfs_repair will have to be increased also if this is okay.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120705220832.GQ19223@dastard>
Date:	Fri, 6 Jul 2012 08:08:32 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Brad Arrington <bradla8@...oo.com>
Cc:	Ben Myers <bpm@....com>, Alex Elder <elder@...nel.org>,
	xfs@....sgi.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ACL: increase the #define XFS_ACL_MAX_ENTRIES to 128
 The xfsprogs xfs_repair will have to be increased also if this is okay.

On Thu, Jul 05, 2012 at 01:33:11PM -0700, Brad Arrington wrote:
> 
> Signed-off-by: Brad Arrington <bradla8@...oo.com>
> ---
>  fs/xfs/xfs_acl.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_acl.h b/fs/xfs/xfs_acl.h
> index 39632d9..716d4d2 100644
> --- a/fs/xfs/xfs_acl.h
> +++ b/fs/xfs/xfs_acl.h
> @@ -22,7 +22,7 @@ struct inode;
>  struct posix_acl;
>  struct xfs_inode;
>  
> -#define XFS_ACL_MAX_ENTRIES 25
> +#define XFS_ACL_MAX_ENTRIES 128

That's an on disk format change - you can't just increase it like
that without some kind of superblock feature bit to indicate that
the limit is 128 rather than 25 on that filesystem.

As it is, if we are going to change it, it will get changed to allow
the maximum number of ACLs an attribute can hold, not another
arbitrary number like 128....

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/