linux-kernel - Re: [PATCH 2/2] msi-laptop: Use struct dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1341559480.4823.176.camel@linux-s257.site>
Date:	Fri, 06 Jul 2012 15:24:40 +0800
From:	joeyli <jlee@...e.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	platform-driver-x86@...r.kernel.org,
	Matthew Garrett <mjg59@...f.ucam.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Frank Seidel <frank@...eidel.de>,
	"Lee, Chun-Yi" <jlee@...ell.com>
Subject: Re: [PATCH 2/2] msi-laptop: Use struct dev_pm_ops for power
 management

於 六，2012-06-30 於 23:57 +0200，Rafael J. Wysocki 提到：
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Make the msi-laptop driver define its PM callbacks through
> a struct dev_pm_ops object rather than by using legacy PM hooks
> in struct platform_driver.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>


This patch good to me.

Acked-by: Lee, Chun-Yi <jlee@...e.com>


Thanks a lot!
Joey Lee

> ---
>  drivers/platform/x86/msi-laptop.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux/drivers/platform/x86/msi-laptop.c
> ===================================================================
> --- linux.orig/drivers/platform/x86/msi-laptop.c
> +++ linux/drivers/platform/x86/msi-laptop.c
> @@ -85,7 +85,8 @@
>  #define MSI_STANDARD_EC_TOUCHPAD_ADDRESS	0xe4
>  #define MSI_STANDARD_EC_TOUCHPAD_MASK		(1 << 4)
>  
> -static int msi_laptop_resume(struct platform_device *device);
> +static int msi_laptop_resume(struct device *device);
> +static SIMPLE_DEV_PM_OPS(msi_laptop_pm, NULL, msi_laptop_resume);
>  
>  #define MSI_STANDARD_EC_DEVICES_EXISTS_ADDRESS	0x2f
>  
> @@ -437,8 +438,8 @@ static struct platform_driver msipf_driv
>  	.driver = {
>  		.name = "msi-laptop-pf",
>  		.owner = THIS_MODULE,
> +		.pm = &msi_laptop_pm,
>  	},
> -	.resume = msi_laptop_resume,
>  };
>  
>  static struct platform_device *msipf_device;
> @@ -752,7 +753,7 @@ err_bluetooth:
>  	return retval;
>  }
>  
> -static int msi_laptop_resume(struct platform_device *device)
> +static int msi_laptop_resume(struct device *device)
>  {
>  	u8 data;
>  	int result;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/