lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 6 Jul 2012 16:44:15 +0800
From:	Wanpeng Li <liwp.linux@...il.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Wanpeng Li <liwp.linux@...il.com>
Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset

On Fri, Jul 06, 2012 at 10:22:42AM +0200, Johannes Weiner wrote:
>On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@...ux.vnet.ibm.com>
>> 
>> Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT.
>
>And nobody is passing anything else.  Which is easy to prove as this
>is a private function.  And there wouldn't even be any harm passing
>something else.  Please don't add stuff like this.

Ok, thank you for your comment.

I also have another two patches, title:

clarify type in memory cgroups
return -EBUSY when oom-kill-disable modified and memcg use_hierarchy, has children

Hopefully, you can review. Thank you Johannes! :-)

Regards,
Wanpeng Li 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists