linux-kernel - Re: [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FF74FA3.4000008@acm.org>
Date:	Fri, 06 Jul 2012 15:50:43 -0500
From:	Corey Minyard <tcminyard@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
CC:	Linux PM mailing list <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH] PM / IPMI: Remove empty legacy PCI PM callbacks

Looks fine to me.

Acked-by: Corey Minyard <cminyard@...sta.com>

On 07/06/2012 03:02 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
>
> The legacy PM callbacks provided by the IPMI PCI driver are
> empty routines returning 0, so they can be safely dropped.
>
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c |   16 ----------------
>   1 file changed, 16 deletions(-)
>
> Index: linux/drivers/char/ipmi/ipmi_si_intf.c
> ===================================================================
> --- linux.orig/drivers/char/ipmi/ipmi_si_intf.c
> +++ linux/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2503,18 +2503,6 @@ static void __devexit ipmi_pci_remove(st
>   	cleanup_one_si(info);
>   }
>   
> -#ifdef CONFIG_PM
> -static int ipmi_pci_suspend(struct pci_dev *pdev, pm_message_t state)
> -{
> -	return 0;
> -}
> -
> -static int ipmi_pci_resume(struct pci_dev *pdev)
> -{
> -	return 0;
> -}
> -#endif
> -
>   static struct pci_device_id ipmi_pci_devices[] = {
>   	{ PCI_DEVICE(PCI_HP_VENDOR_ID, PCI_MMC_DEVICE_ID) },
>   	{ PCI_DEVICE_CLASS(PCI_ERMC_CLASSCODE, PCI_ERMC_CLASSCODE_MASK) },
> @@ -2527,10 +2515,6 @@ static struct pci_driver ipmi_pci_driver
>   	.id_table =     ipmi_pci_devices,
>   	.probe =        ipmi_pci_probe,
>   	.remove =       __devexit_p(ipmi_pci_remove),
> -#ifdef CONFIG_PM
> -	.suspend =      ipmi_pci_suspend,
> -	.resume =       ipmi_pci_resume,
> -#endif
>   };
>   #endif /* CONFIG_PCI */
>   


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/